On Fri, May 10, 2013 at 10:53:41AM +0900, Namhyung Kim wrote:
> On Thu, 9 May 2013 15:32:20 +0200, Jiri Olsa wrote:
> > If single 'p' modifier is specified for event, set the
> > system precise value for perf_events_attr::precise_ip.
> >
> > If more than a single 'p' is specified keep the intended
> > value.
>
> So there's no way to set precise=1 on a system suppports precise=2 using
> this syntax, right? (I don't know whether it makes any sense though.)
right, I abused the single 'p' to get whatever is in sysfs,
which AFAICS should be always the intention..
>
> >
> > If precise is not supported by system, warning is disaplyed.
>
> s/disaplyed/displayed/
ok
>
> >
> > Signed-off-by: Jiri Olsa <jo...@redhat.com>
> > Cc: Corey Ashford <cjash...@linux.vnet.ibm.com>
> > Cc: Frederic Weisbecker <fweis...@gmail.com>
> > Cc: Ingo Molnar <mi...@elte.hu>
> > Cc: Namhyung Kim <namhy...@kernel.org>
> > Cc: Paul Mackerras <pau...@samba.org>
> > Cc: Peter Zijlstra <a.p.zijls...@chello.nl>
> > Cc: Arnaldo Carvalho de Melo <a...@redhat.com>
> > Cc: Andi Kleen <a...@linux.intel.com>
> > Cc: David Ahern <dsah...@gmail.com>
> > Cc: Stephane Eranian <eran...@google.com>
> > ---
> > tools/perf/util/parse-events.c | 40
> > ++++++++++++++++++++++++++++++++++++++--
> > 1 file changed, 38 insertions(+), 2 deletions(-)
> >
> > diff --git a/tools/perf/util/parse-events.c b/tools/perf/util/parse-events.c
> > index 2e3ef10..6be4599 100644
> > --- a/tools/perf/util/parse-events.c
> > +++ b/tools/perf/util/parse-events.c
> > @@ -533,6 +533,26 @@ int parse_events_add_breakpoint(struct list_head
> > **list, int *idx,
> > return add_event(list, idx, &attr, NULL);
> > }
> >
> > +static int precise_default(void)
> > +{
> > + int precise = perf_precise__get();
> > + static int warned;
> > +
> > + /*
> > + * Precise info not supported by by this kernel,
>
> s/by by/by/ :)
ok
>
>
> > + * set 1 as the precise value.
> > + */
> > + if (precise == -1)
> > + precise = 1;
> > +
> > + /* PEBS is not supported here, display warning. */
> > + if (precise == 0 && !warned++)
> > + pr_warning("warning: no precise support, "
> > + "using non-precise event(s)\n");
>
> Please put the message on a single line.
ok
thanks,
jirka
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
