On Fri, May 3, 2013 at 4:31 PM, Lee Jones <[email protected]> wrote:
> The channels reserved for memcpy are the same for all currently > supported platforms. With this in mind, we can ease the platform > data passing requirement by moving these assignments out from > platform code and place them directly into the driver. > > Acked-by: Vinod Koul <[email protected]> > Acked-by: Arnd Bergmann <[email protected]> > Signed-off-by: Lee Jones <[email protected]> (...) > -/* Reserved event lines for memcpy only */ > -static int dma40_memcpy_event[] = { > - DB8500_DMA_MEMCPY_TX_0, > - DB8500_DMA_MEMCPY_TX_1, > - DB8500_DMA_MEMCPY_TX_2, > - DB8500_DMA_MEMCPY_TX_3, > - DB8500_DMA_MEMCPY_TX_4, > - DB8500_DMA_MEMCPY_TX_5, > -}; (...) > +/* Reserved event lines for memcpy only. */ > +static int dma40_memcpy_channels[] = { 56, 57, 58, 59, 60 }; I'm still not OK with named numbers being replaced with hardcoded numbers. Apparently this is a hard review comment so I will go in and patch it myself with a separate patch on top of this. Yours, Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
