On 04/25/2013 12:35 PM, Benjamin Herrenschmidt wrote: > On Thu, 2013-04-25 at 10:23 -0500, Rob Herring wrote: >> Ben, Can I have your Ack for this? The change is straightforward and >> neither of the 2 drivers used the id parameter that is removed. > > Didn't you get my mail about a compile failure caused by this patch ?
No, and I can't find any evidence of a mail in my inbox or in the list archives. > > A quick build test leads to: > > /home/benh/linux-powerpc-test/arch/powerpc/kernel/ibmebus.c: In function > 'ibmebus_bus_device_probe': > /home/benh/linux-powerpc-test/arch/powerpc/kernel/ibmebus.c:344:2: error: > implicit declaration of function 'to_platform_driver' > [-Werror=implicit-function-declaration] > /home/benh/linux-powerpc-test/arch/powerpc/kernel/ibmebus.c:344:6: error: > assignment makes pointer from integer without a cast [-Werror] > /home/benh/linux-powerpc-test/arch/powerpc/kernel/ibmebus.c: In function > 'ibmebus_bus_device_remove': > /home/benh/linux-powerpc-test/arch/powerpc/kernel/ibmebus.c:363:32: error: > initialization makes pointer from integer without a cast [-Werror] > /home/benh/linux-powerpc-test/arch/powerpc/kernel/ibmebus.c: In function > 'ibmebus_bus_device_shutdown': > /home/benh/linux-powerpc-test/arch/powerpc/kernel/ibmebus.c:373:32: error: > initialization makes pointer from integer without a cast [-Werror] > /home/benh/linux-powerpc-test/arch/powerpc/kernel/ibmebus.c: In function > 'ibmebus_bus_legacy_suspend': > /home/benh/linux-powerpc-test/arch/powerpc/kernel/ibmebus.c:420:32: error: > initialization makes pointer from integer without a cast [-Werror] > /home/benh/linux-powerpc-test/arch/powerpc/kernel/ibmebus.c: In function > 'ibmebus_bus_legacy_resume': > /home/benh/linux-powerpc-test/arch/powerpc/kernel/ibmebus.c:431:32: error: > initialization makes pointer from integer without a cast [-Werror] > cc1: all warnings being treated as errors > make[2]: *** [arch/powerpc/kernel/ibmebus.o] Error 1 > make[2]: *** Waiting for unfinished jobs.... > > Haven't had a chance to look too closely today -EJETLAG :-) You need patch 2 of this series to fix this: driver core: move to_platform_driver to platform_device.h which as Arnd pointed out needs to come first. I've fixed that in my tree, but I don't think it warrants another post. Rob -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
