On Wed, Apr 24, 2013 at 07:40:19PM +0100, Stefano Stabellini wrote:
> From: Jon Medhurst <t...@linaro.org>
>
> Add a new 'smp_init' hook to machine_desc so platforms can specify a
> function to be used to setup smp ops instead of having a statically
> defined value. The hook must return true when smp_ops are initialized.
> If false the static mdesc->smp_ops will be used by default.
>
> Signed-off-by: Jon Medhurst <t...@linaro.org>
> Signed-off-by: Nicolas Pitre <nicolas.pi...@linaro.org>
> Signed-off-by: Stefano Stabellini <stefano.stabell...@eu.citrix.com>
> Reviewed-by: Santosh Shilimkar <santosh.shilim...@ti.com>
> ---
> arch/arm/include/asm/mach/arch.h | 4 ++++
> arch/arm/kernel/setup.c | 10 ++++++----
> 2 files changed, 10 insertions(+), 4 deletions(-)
[...]
> if (is_smp()) {
> - if (psci_smp_available())
> - smp_set_ops(&psci_smp_ops);
> - else if (mdesc->smp)
> - smp_set_ops(mdesc->smp);
> + if (!mdesc->smp_init || !mdesc->smp_init()) {
Minor nit, but this feels backwards to me. We usually return 0 on success,
yet we're saying here that if mdesc->smp_init() returns 0, then we go and
override the smp ops.
Will
> + if (psci_smp_available())
> + smp_set_ops(&psci_smp_ops);
> + else if (mdesc->smp)
> + smp_set_ops(mdesc->smp);
> + }
> smp_init_cpus();
> }
> #endif
> --
> 1.7.2.5
>
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
