* Arnd Bergmann <[email protected]> [130423 09:37]: > The omap2 nand device driver calls into the the elm code, which can > be a loadable module, and in that case it cannot be built-in itself. > I can see no reason why the omap2 driver cannot also be a module, > so let's make the option "tristate" in Kconfig to fix this allmodconfig > build error: > > ERROR: "elm_config" [drivers/mtd/nand/omap2.ko] undefined! > ERROR: "elm_decode_bch_error_page" [drivers/mtd/nand/omap2.ko] undefined! > > Signed-off-by: Arnd Bergmann <[email protected]> > Cc: David Woodhouse <[email protected]> > Cc: Artem Bityutskiy <[email protected]> > Cc: Tony Lindgren <[email protected]> > Cc: Afzal Mohammed <[email protected]> > Cc: Russell King <[email protected]> > Cc: [email protected] > --- > drivers/mtd/nand/Kconfig | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/mtd/nand/Kconfig b/drivers/mtd/nand/Kconfig > index 81bf5e5..106b55e 100644 > --- a/drivers/mtd/nand/Kconfig > +++ b/drivers/mtd/nand/Kconfig > @@ -109,7 +109,7 @@ config MTD_NAND_OMAP2 > > config MTD_NAND_OMAP_BCH > depends on MTD_NAND && MTD_NAND_OMAP2 && ARCH_OMAP3 > - bool "Enable support for hardware BCH error correction" > + tristate "Enable support for hardware BCH error correction" > default n > select BCH > select BCH_CONST_PARAMS
Acked-by: Tony Lindgren <[email protected]> While at it, you could also drop the "default n" as that's the default anyways. Regards, Tony -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
