On Thu, 18 Apr 2013, Arnd Bergmann wrote: > On Thursday 18 April 2013, Lee Jones wrote: > > You're right, I am a little confused by them. > > > > I call them 'device type' because that's what they're called already. > > Grep for 'dma_dev_type'. This is the number which gets split into > > event group and line, like this: > > > > event_group = D40_TYPE_TO_GROUP(dev_type); > > event_line = D40_TYPE_TO_EVENT(dev_type); > > > > > and I would put that number first. > > > > So you want me to switch that round so it looks like: > > > > dmas = <<phandle> <dev_type> <fixed_chan> <flags>; > > > > Instead of what I have at the moment: > > > > dmas = <<phandle> <fixed_chan> <dev_type> <flags>; > > > > Correct? > > Yes, that's probably better and more in line with what the other > drivers do. You could also put the fixed_chan last if that helps.
I'd rather keep the flags as the final cell if it's all the same to you? > I would still like to get a confirmation that we actually still > require the fixed channel assignment, since it's just used > in one driver, and that might only be needed for some buggy > hardware revision if we're lucky. Unfortunately not: `git grep "\.use_fixed_channel" <internal_kernel> | grep true | wc -l` 8 -- Lee Jones Linaro ST-Ericsson Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
