On Mon, Apr 15, 2013 at 8:58 AM, Joerg Roedel <j...@8bytes.org> wrote: > On Mon, Apr 15, 2013 at 12:42:00AM +0530, Varun Sethi wrote: >> swap_pci_ref function is used by the IOMMU API code for swapping pci device >> pointers, while determining the iommu group for the device. >> Currently this function was being implemented for different IOMMU drivers. >> This patch moves the function to pci.h so that the implementation can be >> shared across various IOMMU drivers. > > The function is only used in IOMMU code, so I think its fine to keep it > there (unless Bjorn disagrees and wants it in PCI code).
I agree; I don't think there's much benefit in putting something under #ifdef CONFIG_IOMMU_API into pci.h. Maybe there is or could be a shared iommu header file? Bjorn -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
