On 2013年04月11日 01:31, Eric Paris wrote:
> ----- Original Message -----
>> >
>> > __audit_socketcall is an extern function.
>> > better to check its parameters by itself.
>> >
>> > also can return error code, when fail (find invalid parameters).
>> > also use macro instead of real hard code number
>> > also give related comments for it.
>> >
>> > Signed-off-by: Chen Gang <gang.c...@asianux.com>
>> > ---
>> > include/linux/audit.h | 12 ++++++++----
>> > kernel/auditsc.c | 9 ++++++---
>> > net/socket.c | 6 ++++--
>> > 3 files changed, 18 insertions(+), 9 deletions(-)
>> >
>> > diff --git a/include/linux/audit.h b/include/linux/audit.h
>> > @@ -354,7 +358,7 @@ static inline int audit_bprm(struct linux_binprm *bprm)
>> > {
>> > return 0;
>> > }
>> > -static inline void audit_socketcall(int nargs, unsigned long *args)
>> > +static inline int audit_socketcall(int nargs, unsigned long *args)
>> > { }
>> > static inline void audit_fd_pair(int fd1, int fd2)
>> > { }
> This now returns a value but you forgot to return a value. Thus this would
> not even build... I fixed it up myself.
thank you very much.
:-)
--
Chen Gang
Asianux Corporation
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
