On Tue, 09 Apr 2013, Arnd Bergmann wrote: > On Tuesday 09 April 2013, Lee Jones wrote: > > Confusingly d40_log_cfg() is used to set up the logical channel > > configuration registers, but d40_phy_cfg() is used to configure > > physical and logical registers, so it should be called in both > > cases. It is the function call's final attribute which determines > > whether it's a physical or logical channel, not whether the > > function is called or not. > > So how did it ever work? Your description sounds like it was > broken all along, but I would assume that someone tested the code.
>From what I can see, not. My best guess is that the 'test' was to see if the configuration changed using the debug print at the end of the function. I don't see how else the configuration can be written to hardware. -- Lee Jones Linaro ST-Ericsson Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
