>> + nr_running = rq->nr_running ? rq->nr_running : 1; > > This can be cleaned up with proper min/max().
yes, thanks > >> + >> + return rt_util + cfs_util * nr_running; > > Should this nr_running consider tasks in cfs_rq only? Also it seems > there's no upper bound so that it can possibly exceed FULL_UTIL. Yes. we need to consider task number:nr_running, otherwise cpu utilization will never beyond FULL_UTIL, then we can not know if the cpu is overload. So we need the possible maximum utilization bigger than FULL_UTIL. > -- Thanks Alex -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/