Francois Romieu [mailto:rom...@fr.zoreil.com] > Sent: Tuesday, April 02, 2013 6:24 AM > To: Hayeswang > Cc: net...@vger.kernel.org; linux-kernel@vger.kernel.org > Subject: Re: [PATCH net-next 6/7] r8169: add a new chip for RTL8106E > > Hayes Wang <hayesw...@realtek.com> : > [...] > > - move rtl_set_rx_tx_desc_registers to avoid the tx/rx are enabled > > before setting desc registers. > > This is a wholesale change for the 810x family. > > Please explain why issuing rtl_set_rx_tx_desc_registers before writing > ChipCmd is not enough and feed it through a standalone commit. >
According to the new initial flow of this new chip, the tx/rx would be enabled in rtl_hw_start_8168g_2 function. And this function is run before rtl_set_rx_tx_desc_registers. It would be a problem, so I move rtl_set_rx_tx_desc_registers to make sure that the descriptor address would be set before the tx/rx is enabled. It has no influence for the previous chips, and I think the following new chips would base on the new flow. Best Regards, Hayes -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
