On 03/24/2013 08:37 AM, Lubomir Rintel wrote: > On Fri, 2013-03-22 at 20:44 -0600, Stephen Warren wrote: > > Thank you for your response! > >> On 03/22/2013 06:55 AM, Lubomir Rintel wrote: >>> Signed-off-by: Lubomir Rintel <lkundrak at v3.sk> >> >> A commit description would be useful. >> >>> arch/arm/boot/dts/bcm2835.dtsi | 5 + >>> arch/arm/configs/bcm2835_defconfig | 3 +- >>> drivers/char/hw_random/Kconfig | 12 +++ >>> drivers/char/hw_random/Makefile | 1 + >>> drivers/char/hw_random/bcm2835-rng.c | 137 >>> ++++++++++++++++++++++++++++++++++ >> >> This should be split into 3 separate patches: (1) The driver itself, (2) >> the change to bcm2835.dtsi, and (3) the change to bcm2835_defconfig. >> >> Since you're adding a new device to device tree for the first time, you >> should write a binding document for it; most likely >> Documentation/devicetree/bindings/rng/brcm,bcm2835.txt (or perhaps >> /random/ rather than /rng/?) > > Okay. I'm tempted to stick to "rng" instead of "random" as it seems more > consistent to me, but I don't have a strong reason to back it with. What > would > be a good reason for using "random"?
I figured that "random" might be more meaningful/understandable for some people. It's not a big deal either way though. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
