From: Wei Yongjun <yongjun_...@trendmicro.com.cn> sizeof() when applied to a pointer typed expression gives the size of the pointer, not that of the pointed data.
Signed-off-by: Wei Yongjun <yongjun_...@trendmicro.com.cn> --- drivers/mailbox/mailbox.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/mailbox/mailbox.c b/drivers/mailbox/mailbox.c index 5fea5c2..78e52c0 100644 --- a/drivers/mailbox/mailbox.c +++ b/drivers/mailbox/mailbox.c @@ -83,7 +83,7 @@ int mailbox_msg_send(struct mailbox *mbox, struct mailbox_msg *msg) mutex_lock(&mq->mlock); - if (kfifo_avail(&mq->fifo) < (sizeof(msg) + msg->size)) { + if (kfifo_avail(&mq->fifo) < (sizeof(*msg) + msg->size)) { ret = -ENOMEM; goto out; } @@ -93,8 +93,8 @@ int mailbox_msg_send(struct mailbox *mbox, struct mailbox_msg *msg) goto out; } - len = kfifo_in(&mq->fifo, (unsigned char *)msg, sizeof(msg)); - WARN_ON(len != sizeof(msg)); + len = kfifo_in(&mq->fifo, (unsigned char *)msg, sizeof(*msg)); + WARN_ON(len != sizeof(*msg)); if (msg->size && msg->pdata) { len = kfifo_in(&mq->fifo, (unsigned char *)msg->pdata, -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/