On Tue, Mar 19, 2013 at 1:58 PM, Peter Zijlstra <pet...@infradead.org> wrote: > On Tue, 2013-03-19 at 13:50 +0100, Stephane Eranian wrote: >> > Should we not replace: >> > >> > regs.ip = 0; >> > >> > with that memset? It avoids the memset work in a few cases and >> removes >> > the then superfluous clearing of the IP field. >> > >> We could drop it because it's covered by the memset(). > > Yeah, but also place the memset a little lower than you did, avoids the > stack writes when not needed. > Ok, I get it now. Yes, we can move it after the test and drop reg.val = 0.
>> The issue here was that you eventually end up in code_segment_base() >> which >> looks at other uninitialized fields in pt_regs and may cause breakage. > > Right, your changelog said so ;-) > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
