On 03/19/2013 02:47 PM, Dong Hao wrote: > From: Dong Hao <haod...@linux.vnet.ibm.com> > > kobj and ktype are two important attributes which will be used after > kobject_init(),
> and (!kobj)|(!ktype) may cause FS corruption which could not be recovered. delete this line, i am not very convinced about corruption ... > Panic instead of dump_stack() when neither kobj nor ktype is properly > assigned to > detect the bug early. > > Signed-off-by: Dong Hao <haod...@linux.vnet.ibm.com> > --- > lib/kobject.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/lib/kobject.c b/lib/kobject.c > index 279a172..ff9b3c3 100644 > --- a/lib/kobject.c > +++ b/lib/kobject.c > @@ -290,7 +290,7 @@ void kobject_init(struct kobject *kobj, struct kobj_type > *ktype) > > error: > printk(KERN_ERR "kobject (%p): %s\n", kobj, err_str); > - dump_stack(); > + BUG_ON(1); > } > EXPORT_SYMBOL(kobject_init); > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
