On 03/18/2013 04:22 PM, Danny Baumann wrote: > Hi, > >>> diff --git a/drivers/acpi/video.c b/drivers/acpi/video.c >>> index 313f959..9c33871 100644 >>> --- a/drivers/acpi/video.c >>> +++ b/drivers/acpi/video.c >>> @@ -222,7 +222,7 @@ static int acpi_video_device_lcd_set_level(struct >>> acpi_video_device *device, >>> int level); >>> static int acpi_video_device_lcd_get_level_current( >>> struct acpi_video_device *device, >>> - unsigned long long *level, int init); >>> + unsigned long long *level, int raw); >> >> Why not bool? > > For two reasons: > - It previous was int ;-)
Right, but since we are doing something now, we can probably change it for better :-) > - It allowed the invocations of this function to fit within one 80-char > line. the unsigned long long for level made me curious, do we really need that? int would suffice I think. > > Neither reason is terribly strong, so if you prefer, I can convert this > argument to bool. It's OK, I can do the cleaup some time later. Thanks, Aaron -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
