On Thursday 14 March 2013, Fabio Porcedda wrote:
> This patch converts the drivers to use the
> module_platform_driver_probe() macro which makes the code smaller and
> a bit simpler.
>
> Signed-off-by: Fabio Porcedda <[email protected]>
> Cc: Greg Kroah-Hartman <[email protected]>
> Cc: Arnd Bergmann <[email protected]>
> ---
> drivers/misc/atmel_pwm.c | 12 +-----------
> drivers/misc/ep93xx_pwm.c | 13 +------------
> 2 files changed, 2 insertions(+), 23 deletions(-)
The patch itself seems fine, but there are two issues around it:
* The PWM drivers should really get moved to drivers/pwm and converted to the
new
PWM subsystem. I don't know if Hartley or Hans-Christian have plans to do
that already.
* Regarding the use of module_platform_driver_probe, I'm a little worried about
the interactions with deferred probing. I don't think there are any
regressions,
but we should probably make people aware that one cannot return -EPROBE_DEFER
from a platform_driver_probe function.
Arnd
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
