Hello, Andrew.
On Wed, Mar 13, 2013 at 12:46:24PM -0700, Andrew Morton wrote:
> Tejun, can you please confirm that this is how worker_pool_assign_id()
> should look in linux-next?
>
> static int worker_pool_assign_id(struct worker_pool *pool)
> {
> int ret;
>
> do {
> idr_preload(GFP_KERNEL);
> spin_lock_irq(&workqueue_lock);
> ret = idr_alloc(&worker_pool_idr, pool, 0, 0, GFP_NOWAIT);
> if (ret >= 0)
> pool->id = ret;
> spin_unlock_irq(&workqueue_lock);
idr_preload_end();
> } while (ret == -EAGAIN);
>
> return ret < 0 ? ret : 0;
> }
Other than that, it looks good to me.
Thanks!
--
tejun
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
