Ben Hutchings <b...@decadent.org.uk> wrote: > On Fri, 2013-03-08 at 13:51 +1100, Michael Neuling wrote: > > This patch is breaking the celleb_defconfig on powerpc with: > > > > arch/powerpc/kernel/of_platform.c: In function 'of_pci_phb_probe': > > arch/powerpc/kernel/of_platform.c:95:2: error: implicit declaration of > > function 'eeh_add_sysfs_files' [-Werror=implicit-function-declaration] > > In 3.2 this file doesn't (directly) include <asm/eeh.h> which is where > the definition was added. In mainline it does. > > Assuming that this change is actually required for 3.2 (which I'm not > sure about), I suppose we just need to add the #include.
Yep that fixes it. Patch below (for stable 3.2 only) From: Michael Neuling <mi...@neuling.org> Subject: powerpc/eeh: Fix compile error due to missing include file 3.2.40 fails to compile the celleb_defconfig with the following error: arch/powerpc/kernel/of_platform.c: In function 'of_pci_phb_probe': arch/powerpc/kernel/of_platform.c:95:2: error: implicit declaration of function 'eeh_add_sysfs_files' [-Werror=implicit-function-declaration] The following adds the required include file to fix this. Signed-off-by: Michael Neuling <mi...@neuling.org> diff --git a/arch/powerpc/kernel/of_platform.c b/arch/powerpc/kernel/of_platform.c index b10beef..601650f 100644 --- a/arch/powerpc/kernel/of_platform.c +++ b/arch/powerpc/kernel/of_platform.c @@ -26,6 +26,7 @@ #include <asm/topology.h> #include <asm/pci-bridge.h> #include <asm/ppc-pci.h> +#include <asm/eeh.h> #include <linux/atomic.h> #ifdef CONFIG_PPC_OF_PLATFORM_PCI -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
