On Mon, 2013-03-11 at 12:21 +0100, Jiri Olsa wrote: > > pg_nr = offset >> page_shift; > > pg_offset = offset & (1 << page_shift) - 1; > > > > You just wrecked that. > > > > > handle->page &= rb->nr_pages - 1; > > here's ^^^ where the handle->page becomes 0 due to (rb->nr_pages == 0)
then that'll be &= -1, which is a nop, no? Also, you wrecked it for anything that uses some intermediate page order (we currently don't). -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/