Hi Paul, 2013/3/3 Paul Menzel <paulepan...@users.sourceforge.net>: > From: Takahisa Tanaka <mc74h...@gmail.com> > Date: Sun, 3 Mar 2013 14:48:00 +0900 > > The AcpiMmioSel bit is bit 1 in the AcpiMmioEn register, but the current > sp5100_tco driver is using bit 2. > > See 2.3.3 Power Management (PM) Registers page 150 of the > AMD SB800-Series Southbridges Register Reference Guide [1]. > > AcpiMmioEn - RW – 8/16/32 bits - [PM_Reg: 24h] > Field Name Bits Default Description > AcpiMMioDecodeEn 0 0b Set to 1 to enable AcpiMMio space. > AcpiMMIoSel 1 0b Set AcpiMMio registers to be > memory-mapped or IO-mapped space. > 0: Memory-mapped space > 1: I/O-mapped space > > The sp5100_tco driver expects zero as a value of AcpiMmioSel (bit 1). > > Fortunately, no problems were caused by this typo, because the default > value of the undocumented misused bit 2 seems to be zero. > > However, the sp5100_tco driver should use the correct bitmask value. > > [1] http://support.amd.com/us/Embedded_TechDocs/45482.pdf > > Signed-off-by: Takahisa Tanaka <mc74h...@gmail.com> > CC: sta...@vger.kernel.org > Signed-off-by: Paul Menzel <paulepan...@users.sourceforge.net> > --- > v2: Hopefully improved the commit message. > > drivers/watchdog/sp5100_tco.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/watchdog/sp5100_tco.h b/drivers/watchdog/sp5100_tco.h > index 71594a0..2b28c00 100644 > --- a/drivers/watchdog/sp5100_tco.h > +++ b/drivers/watchdog/sp5100_tco.h > @@ -57,7 +57,7 @@ > #define SB800_PM_WATCHDOG_DISABLE (1 << 2) > #define SB800_PM_WATCHDOG_SECOND_RES (3 << 0) > #define SB800_ACPI_MMIO_DECODE_EN (1 << 0) > -#define SB800_ACPI_MMIO_SEL (1 << 2) > +#define SB800_ACPI_MMIO_SEL (1 << 1) > > > #define SB800_PM_WDT_MMIO_OFFSET 0xB00 > -- > 1.7.10.4
I'm sorry for late reply. Thank you for improving the commit log. Regards, Takahisa -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
