Hi Andrew, On Friday 22 February 2013 02:23 AM, Tejun Heo wrote: > On Thu, Feb 21, 2013 at 12:52 PM, Vineet Gupta > <vineet.gup...@synopsys.com> wrote: >> This came to light when calling memblock allocator from arc port (for >> copying flattended DT). If a "0" alignment is passed, the allocator >> round_up() call incorrectly rounds up the size to 0. >> >> round_up(num, alignto) => ((num - 1) | (alignto -1)) + 1 >> >> While the obvious allocation failure causes kernel to panic, it is >> better to warn the caller to fix the code. >> >> Tejun suggested that instead of BUG_ON(!align) - which might be >> ineffective due to pending console init and such, it is better to >> WARN_ON, and continue the boot with a reasonable default align. >> >> Caller passing @size need not be handled similarly as the subsequent >> panic will indicate that anyhow. >> >> Signed-off-by: Vineet Gupta <vgu...@synopsys.com> >> Cc: Andrew Morton <a...@linux-foundation.org> >> Cc: Tejun Heo <t...@kernel.org> >> Cc: Yinghai Lu <ying...@kernel.org> >> Cc: Wanpeng Li <liw...@linux.vnet.ibm.com> >> Cc: Ingo Molnar <mi...@kernel.org> >> Cc: linux...@kvack.org >> Cc: linux-kernel@vger.kernel.org > > Acked-by: Tejun Heo <t...@kernel.org> > > Thanks. >
I'm hoping this will be routed via the mm tree. Thx, -Vineet -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
