Hi Eduardo, > -----Original Message----- > From: Eduardo Valentin [mailto:eduardo.valen...@ti.com] > Sent: Friday, March 01, 2013 3:04 AM > To: R, Durgadoss > Cc: Zhang, Rui; linux...@vger.kernel.org; linux-kernel@vger.kernel.org; > hongbo.zh...@linaro.org; w...@nvidia.com > Subject: Re: [PATCHv3 0/8] Thermal Framework Enhancements > > > Durga, > > > > On 05-02-2013 06:46, Durgadoss R wrote: > > This patch set is a v3 of the previous versions submitted here: > > [v2]: http://lwn.net/Articles/531720/ > > [v1]: https://lkml.org/lkml/2012/12/18/108 > > [RFC]:https://patchwork.kernel.org/patch/1758921/ > > On this version I have some implementation details which applies mostly > for the series. So, I am replying to patch 0 to summarize: > > - Consider using linked list
This I thought through on my RFC itself. I know we have arrays, but using list adds too many members to the structures, and protection becomes really cryptic. > - You may have contention on your indexes and arrays > - overflow on your buffer (carefully check your implementation) > - zone removal condition. can we remove zones with sensors/cdevs/maps > registered? > - Minors on strlcpy, snprintf, devm_ helpers > - documentation in the code for these helper functions and also better > naming.. I will try to take care of these in my next version, as far as I can see. But would really help if you can point the specific code that needs improvement. Thanks, Durga -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
