On Thu, 28 Feb 2013, Li Fei wrote:
>
> Even in failed case of pm_runtime_get_sync, the usage_count
> is incremented. In order to keep the usage_count with correct
> value and runtime power management to behave correctly, call
> pm_runtime_put(_sync) in such case.
>
> Signed-off-by Liu Chuansheng <chuansheng....@intel.com>
> Signed-off-by: Li Fei <fei...@intel.com>
> ---
> drivers/usb/core/hub.c | 3 ++-
> 1 files changed, 2 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/usb/core/hub.c b/drivers/usb/core/hub.c
> index 5480352..f72dede 100644
> --- a/drivers/usb/core/hub.c
> +++ b/drivers/usb/core/hub.c
> @@ -3148,12 +3148,13 @@ int usb_port_resume(struct usb_device *udev,
> pm_message_t msg)
>
> if (port_dev->did_runtime_put) {
> status = pm_runtime_get_sync(&port_dev->dev);
> - port_dev->did_runtime_put = false;
> if (status < 0) {
> dev_dbg(&udev->dev, "can't resume usb port, status
> %d\n",
> status);
> + pm_runtime_put_sync(&port_dev->dev);
> return status;
> }
> + port_dev->did_runtime_put = false;
> }
I don't see much point in this. After a failed resume, the port's
runtime PM status is undefined. Whether or not you do a
pm_runtime_put_sync won't make any difference.
Alan Stern
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
