On 02/27, Andrey Vagin wrote:
>
> +struct ptrace_peeksiginfo_args {
> + __u64 off; /* from which siginfo to start */
Cough... You are optimist. You want to handle the case when the
tracee has 1 << 33 or more pending sigqueues. OK good luck ;)
Looks correct, just one nit.
> + for (i = 0; i < arg.nr; i++) {
> ...
> + data += sizeof(siginfo_t);
> +
> + if (signal_pending(current)) {
> + i++; /* accounting the current siginfo */
> + break;
> + }
Imho, this is confusing. Just do
for (i = 0; i < arg.nr; ) {
...
data += sizeof(siginfo_t);
i++;
if (signal_pending(current))
break;
Oleg.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
