在 2013-02-26二的 18:02 +0900，Namhyung Kim写道： > Hi Michael, > > On Tue, 26 Feb 2013 16:02:02 +1100, Michael Ellerman wrote: > > Commit 18c9e5c "Make it to be able to skip unannotatable symbols" broke > > the build with NO_NEWT=1: > > > > CC builtin-annotate.o > > builtin-annotate.c: In function 'hists__find_annotations': > > builtin-annotate.c:161:4: error: duplicate case value > > builtin-annotate.c:154:4: error: previously used here > > make: *** [builtin-annotate.o] Error 1 > > > > This is because without NEWT support K_LEFT is #defined to -1 in > > utils/hist.h > > > > Fix it by shifting the K_LEFT/K_RIGHT #defines out of the likely range > > of error values. > > Argh, didn't check NO_NEWT build on this, sorry. > > The hist_entry__tui_annotate() - hence, symbol__tui_annotate() - returns > either key code or error code. This is not good IMHO but not sure it's > worth refactoring. Maybe we can move the error check to under default > case so that possible future error checks to be done?
or can we skip gui-code-snippet when there's no gui library? anyway, for present fix-up, we can just temporarily change K_LEFT value like Michael's or my patch, I think. > > Thanks, > Namhyung > -- > To unsubscribe from this list: send the line "unsubscribe linux-kernel" in > the body of a message to majord...@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > Please read the FAQ at http://www.tux.org/lkml/ -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
