On 26/02/13 13:58, Laxman Dewangan wrote:
On Tuesday 26 February 2013 06:51 PM, Ian Lartey wrote:
this patch depenfs on [PATCH] mfd: palmas: is_palmas_charger needed by
multiple drivers

Palmas charger has 16 GPIOs
add palmas_gpio_[read|write|update] api to take account
second bank of GPIOs

Signed-off-by: Ian Lartey <i...@slimlogic.co.uk>
Signed-off-by: Graeme Gregory <g...@slimlogic.co.uk>
---

+    /* palmas charger has 16 gpios */
+    if (is_palmas_charger(palmas->product_id))
+        palmas_gpio->gpio_chip.ngpio = 16;
+
what happen if it is not palma charger?
palmas_gpio->gpio_chip.ngpio = 8; is missing or it will overwrite
somewhere.


the non palmas charger value of ngpio remains where it was  -
but you have shown up an error in the ordering - Thanks

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Reply via email to