On Fri, Feb 22, 2013 at 11:01:18AM +0400, Alexander Shiyan wrote: > > On Thu, Feb 21, 2013 at 07:29:02PM +0400, Alexander Shiyan wrote: > > > This patch allow using syscon driver from the platform data, i.e. > > > possibility using driver on systems without oftree support. > > > For search syscon device from the client drivers, > > > "syscon_regmap_lookup_by_pdevname" function was added. > > > > > > Signed-off-by: Alexander Shiyan <shc_w...@mail.ru> > > > > [...] > > > > > + syscon->base = devm_ioremap_resource(dev, res); > > > + if (!syscon->base) > > > > Is this correct? > > Hmm, of course IS_ERR should be used here... > v5? >
Yes. >From here: https://lkml.org/lkml/2013/1/21/140 It seems it is. > > > > > + return -EBUSY; Both this line could also be changed. > > > > > > > Otherwise, i'm also ok with this patch. > > Acked-by: Dong Aisheng <dong.aish...@linaro.org> > > > > BTW, i did not see Samuel's tree having this new API. > > So, who will pick this patch? > > I have same question. I CCed Thierry and Greg who may know it. Regards Dong Aisheng -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
