Re: 2.4.4-pre3: lvm.c patch results in "hanging" mount or swapon

[Jens Axboe]

On Sun, Apr 15 2001, Arjan Filius wrote:
> Hello,
> 
> While trying kernel 2.4.4-pre3 i found a "hanging" swapon (my swap is on
> LVM), same effect for "mount -a". 2.4.3 works properly.
> 
> I found ./drivers/md/lvm.c is patched, and restoring the lvm.c from 2.4.3
> resulted in normal operation.
> 
> I Found LVM/0.9.1_beta7 makes some notes about the patch, so i tried that
> (beta7), but no luck, only 2.4.3:lvm.c worked ok.

Small buglet in the buffer_IO_error out path, I maybe that's it...

-- 
Jens Axboe


--- /opt/kernel/linux-2.4.4-pre3/drivers/md/lvm.c       Sun Apr 15 16:24:13 2001
+++ drivers/md/lvm.c    Sun Apr 15 16:23:36 2001
@@ -1675,8 +1675,10 @@
                               struct buffer_head *bh)
 {
        int ret = lvm_map(bh, rw);
-       if (ret < 0)
+       if (ret < 0) {
+               ret = 0;
                buffer_IO_error(bh);
+       }
        return ret;
 }