On Fri, 2013-02-15 at 10:45 -0200, Mauro Carvalho Chehab wrote:
> Provide a better infrastructure for printk's inside the driver:
> - use edac_dbg() for debug messages;
> - standardize the usage of pr_info();
> - provide warning about the risk of relying on this
> driver.
[]
> diff --git a/drivers/edac/ghes_edac.c b/drivers/edac/ghes_edac.c
[]
> @@ -80,7 +80,8 @@ static void ghes_edac_dmidecode(const struct dmi_header
> *dh, void *arg)
> dimm_fill->count, 0, 0);
>
> if (entry->size == 0xffff) {
> - pr_info(GHES_PFX "Can't get dimm size\n");
> + pr_info(GHES_PFX "Can't get DIMM%i size\n",
> + dimm_fill->count);
Perhaps these should use
#define pr_fmt(fmt) KBUILD_MODNAME ": " fmt
and remove GHEX_PFX from all the pr_<level>()'s?
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
