On Fri, 08 Feb 2013 18:05:52 +0800
Jeremy Kerr <j...@ozlabs.org> wrote:
> > I'll do this for now:
> >
> > ---
> > a/tools/testing/selftests/efivarfs/Makefile~selftests-add-tests-for-efivarfs-fix
> > +++ a/tools/testing/selftests/efivarfs/Makefile
> > @@ -6,7 +6,7 @@ test_objs = open-unlink
> > all: $(test_objs)
> >
> > run_tests: all
> > - @./efivarfs.sh || echo "efivarfs selftests: [FAIL]"
> > + @/bin/sh ./efivarfs.sh || echo "efivarfs selftests: [FAIL]"
> >
> > clean:
> > rm -f $(test_objs)
> >
> > but I'm not sure I did it right :(
>
> efivarfs.sh requires bash currently, so we'll need to call this explicitly:
>
> + @/bin/bash ./efivarfs.sh || echo "efivarfs selftests: [FAIL]"
>
> Is this okay?
Judging from ./Makefile:
# SHELL used by kbuild
CONFIG_SHELL := $(shell if [ -x "$$BASH" ]; then echo $$BASH; \
else if [ -x /bin/bash ]; then echo /bin/bash; \
else echo sh; fi ; fi)
bash is "optional" (this seems dumb, because all of us have
bash and we won't test /bin/sh).
But I expect that anyone who has an interest in running the selftests
is capable of making /bin/bash appear, so I'll make that change.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
