On Tue, Feb 5, 2013 at 7:36 AM, Vishwanathrao Badarkhe, Manish
<manish...@ti.com> wrote:
> I made following changes, in order to update "dip->p" pointer with
> correct value:
>
> - if (!dpi->p) {
> + if (IS_ERR_OR_NULL(dpi->p)) {
> dpi->p = devm_pinctrl_get(dev);
> - if (IS_ERR_OR_NULL(dpi->p)) {
> - int ret = PTR_ERR(dpi->p);
> -
> - dev_dbg(dev, "no pinctrl handle\n");
> - /* Only return deferrals */
> - if (ret == -EPROBE_DEFER)
> - return ret;
> - return 0;
> - }
> + ret = PTR_ERR(dpi->p);
> + dev_dbg(dev, "no pinctrl handle\n");
> + /* Only return deferrals */
> + if (ret == -EPROBE_DEFER)
> + return ret;
> + return 0;
This is based on some old code that I wrote ages ago. Check the
pinctrl tree or linux-next for the latest core pin grabbing code.
Use that instead.
Yours,
Linus Walleij
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
