On Sun, 2013-02-03 at 17:26 +0000, Sean Young wrote: > On Sun, Feb 03, 2013 at 03:47:45PM +0100, Ben Hutchings wrote: > > 3.2-stable review patch. If anyone has any objections, please let me know. > > > > ------------------ > > > > From: Sean Young <s...@mess.org> > > > > commit 65ecc9c02dbad033a73a32916d17c107c5b25031 upstream. > > > > The legacy serial driver will detect the Winbond CIR device as a serial > > port, since it looks exactly like a serial port unless you know what > > it is from the PNP ID. > > > > Here we track this port as a special PORT_8250_CIR type, preventing the > > legacy serial driver from probing it. > > This commit relies on an earlier commit which ensures that 8250 PNP probe > is done before legacy 8250 probe, else the Winbond CIR device will be > claimed by the legacy 8250 driver rendering above commit useless. > > commit 835d844d1a28efba81d5aca7385e24c29d3a6db2 > Author: Sean Young <s...@mess.org> > Date: Fri Sep 7 19:06:23 2012 +0100 > > 8250_pnp: do pnp probe before legacy probe > > We first probe the legacy serial ports and then check pnp. If there > is a non-standard configuration then this might not work, also this > change is needed so we can blacklist Winbond CIR based on PNP ID. > > For this to work the 8250_pnp driver must be merged into the 8250 > module.
That looks a bit too disruptive for stable. I added the Winbond CIR
patch because commit ebebd49a8eab ('8250/16?50: Add support for Broadcom
TruManage redirected serial port') textually depends on it and it looked
like a worthwhile fix too. Since this doesn't do anything on its own,
I'll drop it and rebase the TruManage patch.
Ben.
--
Ben Hutchings
Everything should be made as simple as possible, but not simpler.
- Albert Einstein
signature.asc
Description: This is a digitally signed message part
