[PATCH v2 1/2] AMD,x86: Clean up init_amd()

[Boris Ostrovsky]

Clean up multiple declarations of variable used for rd/wrmsr

Signed-off-by: Boris Ostrovsky <boris.ostrov...@amd.com>
---
 arch/x86/kernel/cpu/amd.c |   29 ++++++++++++-----------------
 1 files changed, 12 insertions(+), 17 deletions(-)

diff --git a/arch/x86/kernel/cpu/amd.c b/arch/x86/kernel/cpu/amd.c
index 15239ff..dd4a5b6 100644
--- a/arch/x86/kernel/cpu/amd.c
+++ b/arch/x86/kernel/cpu/amd.c
@@ -518,10 +518,9 @@ static void __cpuinit early_init_amd(struct cpuinfo_x86 *c)
 static void __cpuinit init_amd(struct cpuinfo_x86 *c)
 {
        u32 dummy;
-
-#ifdef CONFIG_SMP
        unsigned long long value;
 
+#ifdef CONFIG_SMP
        /*
         * Disable TLB flush filter by setting HWCR.FFDIS on K8
         * bit 6 of msr C001_0015
@@ -559,12 +558,10 @@ static void __cpuinit init_amd(struct cpuinfo_x86 *c)
                 * (AMD Erratum #110, docId: 25759).
                 */
                if (c->x86_model < 0x14 && cpu_has(c, X86_FEATURE_LAHF_LM)) {
-                       u64 val;
-
                        clear_cpu_cap(c, X86_FEATURE_LAHF_LM);
-                       if (!rdmsrl_amd_safe(0xc001100d, &val)) {
-                               val &= ~(1ULL << 32);
-                               wrmsrl_amd_safe(0xc001100d, val);
+                       if (!rdmsrl_amd_safe(0xc001100d, &value)) {
+                               value &= ~(1ULL << 32);
+                               wrmsrl_amd_safe(0xc001100d, value);
                        }
                }
 
@@ -617,13 +614,12 @@ static void __cpuinit init_amd(struct cpuinfo_x86 *c)
        if ((c->x86 == 0x15) &&
            (c->x86_model >= 0x10) && (c->x86_model <= 0x1f) &&
            !cpu_has(c, X86_FEATURE_TOPOEXT)) {
-               u64 val;
 
-               if (!rdmsrl_safe(0xc0011005, &val)) {
-                       val |= 1ULL << 54;
-                       wrmsrl_safe(0xc0011005, val);
-                       rdmsrl(0xc0011005, val);
-                       if (val & (1ULL << 54)) {
+               if (!rdmsrl_safe(0xc0011005, &value)) {
+                       value |= 1ULL << 54;
+                       wrmsrl_safe(0xc0011005, value);
+                       rdmsrl(0xc0011005, value);
+                       if (value & (1ULL << 54)) {
                                set_cpu_cap(c, X86_FEATURE_TOPOEXT);
                                printk(KERN_INFO FW_INFO "CPU: Re-enabling "
                                  "disabled Topology Extensions Support\n");
@@ -637,11 +633,10 @@ static void __cpuinit init_amd(struct cpuinfo_x86 *c)
         */
        if ((c->x86 == 0x15) &&
            (c->x86_model >= 0x02) && (c->x86_model < 0x20)) {
-               u64 val;
 
-               if (!rdmsrl_safe(0xc0011021, &val) && !(val & 0x1E)) {
-                       val |= 0x1E;
-                       wrmsrl_safe(0xc0011021, val);
+               if (!rdmsrl_safe(0xc0011021, &value) && !(value & 0x1E)) {
+                       value |= 0x1E;
+                       wrmsrl_safe(0xc0011021, value);
                }
        }
 
-- 
1.7.1


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/