On Fri, Jan 25, 2013 at 2:14 PM, Arnd Bergmann <a...@arndb.de> wrote:
> If the twl4030_write_script function gets called with
> a zero length argument, its return value does not
> get set. We know that all scripts have a nonzero
> length, but returning an error in case they ever
> do is probably appropriate.
>
> Without this patch, building omap2plus_defconfig results in:
>
> drivers/mfd/twl4030-power.c: In function 'load_twl4030_script':
> drivers/mfd/twl4030-power.c:414:5: error: 'err' may be used uninitialized in
> this function
Reviewed-by: Amit Kucheria <amit.kuche...@linaro.org>
> Signed-off-by: Arnd Bergmann <a...@arndb.de>
> Cc: Samuel Ortiz <sa...@linux.intel.com>
> Cc: Peter Ujfalusi <peter.ujfal...@ti.com>
> Cc: Kevin Hilman <khil...@ti.com>
> Cc: Amit Kucheria <amit.kuche...@linaro.org>
> ---
> drivers/mfd/twl4030-power.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/mfd/twl4030-power.c b/drivers/mfd/twl4030-power.c
> index 4dae241..dd362c1 100644
> --- a/drivers/mfd/twl4030-power.c
> +++ b/drivers/mfd/twl4030-power.c
> @@ -159,7 +159,7 @@ out:
> static int twl4030_write_script(u8 address, struct twl4030_ins *script,
> int len)
> {
> - int err;
> + int err = -EINVAL;
>
> for (; len; len--, address++, script++) {
> if (len == 1) {
> --
> 1.8.0
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
