Hi, On Tue, Jan 22, 2013 at 4:05 PM, Bernd Schubert <[email protected]> wrote: > Hello Nicolas, > > > On 01/22/2013 03:31 PM, Nicolas Palix wrote: >> >> Hi, >> >> Thank you Bernd for your proposition. >> >> I added Michal in CC, who is responsible for the integration. > > > Oh, sorry, I CCed everyone, but forgot Michal.
Michal, should we consider adding you to the MAINTAINERS of Coccinelle ? > > >> >> I was wondering if the V variable which already exists would not be better >> than introducing a new variable. Bernd, is there any reason to not use V ? > > > I'm fine using 'V' either. OK. Could you resubmit with V, please ? > > >> >> Your patch also remove the check of the ONLINE variable. In doing so, >> I think that your patch will badly interfere with the online checking >> performed with the C variable. Am I missing something ? > > > Hmm, I probably should have told in the patch description that verbosity > defaults to 0 now. Shall I revert or make an extra patch for that? With the > current patch and ONLINE != 0 nothing will change. I am personally fine with cutting off the verbosity by default. Could you add a comment on how to turn it on in the initial message of the ONLINE mode which is currently only about false positives, and add few words in the change log ? About your other patch, could you resubmit it with V too ? Thanks. Regards, > > > Cheers, > Bernd > > > >> >> Regards, >> >> On Tue, Jan 22, 2013 at 2:34 PM, Bernd Schubert >> <[email protected]> wrote: >>> >>> Simply running "make coccicheck" returns very verbose output and warnings >>> might not be noticed. Allow the user to set the verbosity level. >>> >>> >>> Signed-off-by: Bernd Schubert <[email protected]> >>> CC: Julia Lawall <[email protected]> >>> CC: Nicolas Palix <[email protected]> >>> CC: [email protected] >>> --- >>> scripts/coccicheck | 8 +++++++- >>> 1 file changed, 7 insertions(+), 1 deletion(-) >>> >>> diff --git a/scripts/coccicheck b/scripts/coccicheck >>> index 1a49d1c..eab0b00 100755 >>> --- a/scripts/coccicheck >>> +++ b/scripts/coccicheck >>> @@ -2,6 +2,12 @@ >>> >>> SPATCH="`which ${SPATCH:=spatch}`" >>> >>> +if [ -z "$VERBOSE" ] ; then >>> + RUN_VERBOSE=0 >>> +else >>> + RUN_VERBOSE=$VERBOSE >>> +fi >>> + >>> if [ "$C" = "1" -o "$C" = "2" ]; then >>> ONLINE=1 >>> >>> @@ -55,7 +61,7 @@ coccinelle () { >>> # >>> # $SPATCH -D $MODE $FLAGS -parse_cocci $COCCI $OPT > /dev/null >>> >>> - if [ "$ONLINE" = "0" ] ; then >>> + if [ "$RUN_VERBOSE" != "0" ] ; then >>> >>> FILE=`echo $COCCI | sed "s|$srctree/||"` >>> >>> >> >> >> > -- Nicolas Palix -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
