On Mon, Jan 14, 2013 at 05:23:46PM +0000, Russell King - ARM Linux wrote: > On Mon, Jan 14, 2013 at 05:18:53PM +0000, Cong Ding wrote: > > the pointer cpu_pmu is used without null pointer dereference check, and is > > checked after the using of it, so we move the null pointer check to before > > the > > first use. > > The NULL pointer check is not necessary. cpu_pmu_init() is called > after cpu_pmu has already been dereferenced by its caller: > > cpu_pmu = pmu; > cpu_pmu->plat_device = pdev; > cpu_pmu_init(cpu_pmu); > > So... > > > - /* Ensure the PMU has sane values out of reset. */ > > - if (cpu_pmu && cpu_pmu->reset) > > Just replace this with: > if (cpu_pmu->reset) Thanks Russell, I will send version 2.
- cong -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
