* Oleg Nesterov <o...@redhat.com> [2013-01-08 18:58:22]: > On 01/08, Srikar Dronamraju wrote: > > > > (One simple check below) > > > > Acked-by: Srikar Dronamraju <sri...@linux.vnet.ibm.com> > > Thanks, > > > > @@ -1072,11 +1064,8 @@ static int xol_add_vma(struct xol_area *area) > > > smp_wmb(); /* pairs with get_xol_area() */ > > > mm->uprobes_state.xol_area = area; > > > ret = 0; > > > - > > > -fail: > > > + fail: > > > > Not sure if the space before label is intentional? > > Its true of other labels below also. > > Yes, this was intentional although almost subconscious. > > Personally I prefer to add a space before the label, this helps > /usr/bin/diff to not confuse this label with the function name. > > But I can stop this if you dislike.
I dont have any preference. Just wanted to check if it was intentional or accidental. I thought checkpatch.pl cribs for this. I think somebody while reviewing my patches had pointed out the same to me. I cant remember who and probably my format wasnt just a single space before label. > > Oleg. > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
