On Wed, Jan 09, 2013 at 09:12:29AM +0000, R, Durgadoss wrote: > Hi Greg, > > > -----Original Message----- > > From: Greg KH [mailto:gre...@linuxfoundation.org] > > Sent: Tuesday, January 08, 2013 12:54 AM > > To: R, Durgadoss > > Cc: Zhang, Rui; linux...@vger.kernel.org; linux-kernel@vger.kernel.org; > > eduardo.valen...@ti.com; hongbo.zh...@linaro.org; w...@nvidia.com > > Subject: Re: [PATCH 7/9] Thermal: Make PER_ZONE values configurable > > > > On Mon, Jan 07, 2013 at 12:43:24PM +0530, Durgadoss R wrote: > > > This patch makes MAX_SENSORS_PER_ZONE and > > > MAX_CDEVS_PER_ZONE values configurable. The > > > default value is 1, and range is 1-12. > > > > Why would we ever want to change this? Why make this configurable at > > all, how is a distro supposed to set this value? > > > > Shouldn't it be specified from the driver itself? > > These are platform level parameters, that can differ for various platforms. > (Mostly due to board design and thermistor layouts). Stand-alone thermal > sensor drivers are not (need not be) aware of these values.
Ok, and how does anyone know how to set them properly? > That's why these values are made configurable. Pushing work onto other people, without telling them what they need to do, isn't nice. Please, either make it auto-configurable, or don't make it configurable at all. As it is, this is useless for a distro, or any "normal" user, right? If these are platform specific things, shouldn't they be defined in the platform data for the hardware? thanks, greg k-h -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
