Running with kmemleak shows that this driver leaks every skb allocated in routine htc_connect_service() whether the service connection succeeds or fails.
Signed-off-by: Larry Finger <larry.fin...@lwfinger.net> Cc: Stable <sta...@vger.kernel.org> Cc: "Luis R. Rodriguez" <mcg...@qca.qualcomm.com> Cc: Vasanthakumar Thiagarajan <vthia...@qca.qualcomm.com> Cc: Senthil Balasubramanian <senth...@qca.qualcomm.com> Cc: linux-wirel...@vger.kernel.org Cc: ath9k-de...@lists.ath9k.org Cc: net...@vger.kernel.org Cc: linux-kernel@vger.kernel.org --- drivers/net/wireless/ath/ath9k/htc_hst.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/net/wireless/ath/ath9k/htc_hst.c b/drivers/net/wireless/ath/ath9k/htc_hst.c index 4a9570d..a304748 100644 --- a/drivers/net/wireless/ath/ath9k/htc_hst.c +++ b/drivers/net/wireless/ath/ath9k/htc_hst.c @@ -278,10 +278,12 @@ int htc_connect_service(struct htc_target *target, if (!time_left) { dev_err(target->dev, "Service connection timeout for: %d\n", service_connreq->service_id); - return -ETIMEDOUT; + ret = -ETIMEDOUT; + goto err; } *conn_rsp_epid = target->conn_rsp_epid; + kfree_skb(skb); return 0; err: kfree_skb(skb); -- 1.7.10.4 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/