Hello, Rafael. On Sat, Dec 22, 2012 at 12:53:29PM +0100, Rafael J. Wysocki wrote: > On Friday, December 21, 2012 05:57:01 PM Tejun Heo wrote: > > There's no need to test whether a (delayed) work item in pending > > before queueing, flushing or cancelling it. Most uses are unnecessary > > and quite a few of them are buggy. > > Can you please say why they are buggy?
Usually one of the following two reasons. * The user gets confused and fails to handle !PENDING && currently executing properly. * work_pending() doesn't have any memory barrier and the caller assumes work_pending() is somehow properly synchronized by itself. Thanks. -- tejun -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/