On Tue, 25 Dec 2012 07:05:55 +0200
Gleb Natapov <g...@redhat.com> wrote:
> > Other parts are doing "if (!slot->dirty_bitmap)" to see if the slot
> > is in dirty logging mode. If you prefer, we can do the same here.
> >
> Does not matter to me. If you think it will be more consistent do it.
No preference at the moment. But since .dirty_bitmap and .rmap may be
changed to control free_physmem(new, old) behaviour, I'll keep the code
as is.
I'll send some patches to clean up the current "mem, new, old, slot"
games in __kvm_set_memory_region() later. I was confused many times
by these.
In addition, passing old slot by value to kvm_arch_commit_memory_region()
should be fixed as well. The structure is too big to copy.
Thanks,
Takuya
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
