On 12/14/2012 08:08 AM, Dave Jones wrote: > On Fri, Dec 14, 2012 at 09:21:50AM +0100, Andrew Lunn wrote: > > > > Given this seems to be dependant on device-tree, shouldn't there be > > > some 'depends on' in the kconfig to prevent this showing up on > architectures > > > that don't implement it ? > > > > > > > +menuconfig POWER_RESET > > > > + bool "Board level reset or power off" > > > > + help > > > > + Provides a number of drivers which either reset a complete > board > > > > + or shut it down, by manipulating the main power supply on the > board. > > > > + > > > > + Say Y here to enable board reset and power off > > > > + > > > > +config POWER_RESET_GPIO > > > > + bool "GPIO power-off driver" > > > > + depends on OF_GPIO && POWER_RESET > > > > Don't these depends on here do what you want? > > I think it needs to be on the menuconfig, rather than the child options. > I don't have OF_GPIO, but I still got asked for the former.
The menuconfig enables a class of drivers (at least theoretically in the future, when more such drivers turn up), and there's no reason to believe that all of those drivers will depend on OF. So in my opinion, making POWER_RESET_GPIO depend on OF makes sense, but making POWER_RESET depend on it doesn't. Another solution might be to remove the menuconfig, and just include the option for the individual driver. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
