* David Ahern <dsah...@gmail.com> wrote:
> On 12/13/12 10:02 AM, Linus Torvalds wrote:
>
> From your response to Ingo I take it you looked into other cases.
> I'll summarize here to make sure we are on the same page:
>
> 1. guest only profiling from the host
> perf {record|top} -e cycles:G
>
> 2. host only profiling
> perf {record|top} -e cycles:H
>
> These are 4 existing use cases that toggle exclude_guest and do work
> today for those who care. Not the lack of precise attribute on the
> commands. These are the existing use cases that break by inverting
> the logic in the kernel.
>
> The problem child is perf record -e cycles:ppG. [...]
The #1 problem child in this particular case, the one you should
care about most is:
perf record -e cycles:pp
As 99% of the people won't be doing any host or guest side
profiling, they just want to do profiling.
The above G/H variants are the 1%.
So make sure the default works fine, that old binaries don't
stop working - and then you can automatically (by default)
exclude guest profiling if PEBS is enabled, and only ever reject
profiling in the very specific case of:
perf record -e cycles:ppG
where the user asks for something we don't support (yet).
So please stop thinking exclusively with a virtualization hat
on, first think with a generic kernel developer hat on. Once all
those cases work, make the virtualization case do the right
thing as well.
We can fix all these cases properly and automatically, users
don't need to specify flags they don't care about, old binaries
will work and no VMs will crash.
Ok? So now we need a patch that does all that - otherwise we'll
have to revert the one that added the regression.
Thanks,
Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
