On Fri, 07 Dec 2012, Chris Wilson <ch...@chris-wilson.co.uk> wrote: > On Fri, 07 Dec 2012 13:47:46 +0200, Jani Nikula <jani.nik...@linux.intel.com> > wrote: >> >> On Thu, 06 Dec 2012, Tim Gardner <tim.gard...@canonical.com> wrote: >> > + if (!saved_mode) { >> > + pr_err("i915: Could not allocate saved display mode.\n"); >> >> Please use DRM_ERROR(). > > Truthfully neither, but join the growing petition to get real errorcodes > back to userspace!
Heh, agreed, but in the mean time (i.e. before hell freezes over) I think we should prefer DRM_ERROR over pr_err for consistency. Jani. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/