On Thu, 2012-12-06 at 00:08 -0800, Dmitry Torokhov wrote:
> [...]
Hi Dmitry-
Thanks again for your review. The forthcoming PATCH v6 addresses all of
your requests, except for:
> > + __set_bit(INPUT_PROP_BUTTONPAD, input->propbit);
>
> I do not think it should be marked INPUT_PROP_BUTTONPAD if it has
> physical buttons...
This device (my particular Cypress Trackpad unit anyway) does not have
physical buttons. The pad is clickable; I think it is a standard
"buttonpad" device.
And just FYI, this issue has been addressed but to answer your question:
> > +
> > + if (cytp->mode & CYTP_BIT_ABS_MASK) {
>
> It can't be anything else, can it?
It can: in the case when the mode hasn't been set at all yet (during
detect and reconnect). I cleaned up the logic of this routine
(cypress_validate_byte) and added explanatory comments.
-Kamal
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
