On 05/12/12 11:05, Michal Marek wrote: > Dne 5.12.2012 11:30, James Hogan napsal(a): >> However I think it's unfortunate having to stringify from C as it's >> pretty much always required to be in string form when used from a C >> file, usually in an asm block. Any objection to defining SYMBOL_PREFIX >> with the quotes around it for _c_flags only? E.g. see below > > > After Takashi's patch is applied, there will be no user of the > SYMBOL_PREFIX in C source. But it would probably be more convenient for > potential new users.
Yes indeed (so the C related bits could indeed be dropped for now). I'd likely change this patch to use it though: http://thread.gmane.org/gmane.linux.kernel.cross-arch/15586/focus=15593 > >> +_c_sym_flags = -DSYMBOL_PREFIX=\"$(patsubst "%",%,$(CONFIG_SYMBOL_PREFIX))\" > > Maybe simply > > -DDSYMBOL_PREFIX='$(or $(CONFIG_SYMBOL_PREFIX),"")' > > ? The single quotes are needed either way, to prevent the shell eating > the double quotes. Yep, works for me (makefiles aren't one of my strengths!) Cheers James -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
