> > +   if (!dev) {
> > +           pr_info("PCI AER Cannot get PCI device
> %04x:%02x:%02x.%d\n",
> > +                   pcie->device_id.segment, pcie->device_id.bus,
> > +                   pcie->device_id.slot, pcie->device_id.function);
> 
> Hmm... please correct if I'm wrong, but an error happened at PCI, and
> also a
> kernel bug that prevented it to get the proper PCI device...
> 
> IMHO, the message here should be stronger, and likely printed via
> pr_err().
> 

Mauro,

I modeled this message after other places in the kernel where this function 
failed.  So I figured it would be safe to be consistent there.  I agree though 
that it should be pr_err().  I can make that change.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Reply via email to