On 11/30/2012 06:05 AM, Paul E. McKenney wrote:
> On Thu, Nov 29, 2012 at 04:46:09PM +0800, Lai Jiangshan wrote:
>> Old srcu implement requires sp->completed is loaded in
>> RCU-sched(preempt_disable()) section.
>>
>> The new srcu is now not RCU-sched based, it doesn't require the load of
>> sp->completed and the access to counter must be in the same RCU-sched
>> read site C.S., so we use ACCESS_ONCE() instead, and move it out of
>> the preempt_disable() section, preempt_disable() section is only used
>> for percpu data, not for RCU-sched.
>>
>> The resulted code is almost as the same as before, but it helps people to
>> understand the code, and it avoids to add surprise to reviewer: "why we need
>> rcu_read_lock_sched_held() here?"
>
> The first seven patches look good!
>
> One question about this one -- the current code provided dependency
> ordering between the fetch of idx and the increment, but the code after
> this patch would not provide this ordering (at least not on Alpha,
> and maybe also not in presence of aggressive compiler optimizations).
>
> In the immortal words of MSDOS, "Are you sure?"
Sure, the update site doesn't modify the percpu counter, so there is
no dependency mb needed in read-site. I can ask "where is the corresponding
mb which is paired with this dependency mb?"
The correctness of SRCU is based on
the wait in synchrinize_srcu()
the counter and seq and the mbs between them
X: sp->completed is not necessary here except for reporting how many GP
passed.
The starvation-free of SRCU is based on
split counter and seq into two index,
split the wait into two waits for both index
add sp->completed field
the flip between the two waits
-> the index for wait and the index for late-enough-after-flip
read-site are different.
Thanks,
Lai
>> Signed-off-by: Lai Jiangshan <la...@cn.fujitsu.com>
>> ---
>> kernel/srcu.c | 3 +--
>> 1 files changed, 1 insertions(+), 2 deletions(-)
>>
>> diff --git a/kernel/srcu.c b/kernel/srcu.c
>> index 38a762f..224400a 100644
>> --- a/kernel/srcu.c
>> +++ b/kernel/srcu.c
>> @@ -294,9 +294,8 @@ int __srcu_read_lock(struct srcu_struct *sp)
>> {
>> int idx;
>>
>> + idx = ACCESS_ONCE(sp->completed) & 0x1;
>> preempt_disable();
>> - idx = rcu_dereference_index_check(sp->completed,
>> - rcu_read_lock_sched_held()) & 0x1;
>> ACCESS_ONCE(this_cpu_ptr(sp->per_cpu_ref)->c[idx]) += 1;
>> smp_mb(); /* B */ /* Avoid leaking the critical section. */
>> ACCESS_ONCE(this_cpu_ptr(sp->per_cpu_ref)->seq[idx]) += 1;
>> --
>> 1.7.4.4
>>
>
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
