On Thu, Nov 29, 2012 at 02:09:51PM +0100, Marko Katić wrote: > Well, the commit message was short because i thought it was a quick > and obvious fix.
Don't always expect the person who ends up applying your patch to know what your patch is doing. Don't expect people who are looking back through the git history to look at the patch to work out whether your commit is relevant to them. I suspect Andrew Morton doesn't know what a "SCOOP" or "AKITA" is... Commit messages are there not only to describe the change, but also say why the change is necessary. Think about it as your chance to "sell" the patch. One good step would be to include the warning message dump from the kernel (your subject line says you're hitting a WARN_ON so include that.) At least then people can see your starting point for the patch. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
